Add additional Hobart support. v1.0.0.d0004 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok. It turned out to be a compiler issue with NAG 6.1. I moved to NAG 6.2 and it runs fine. Dave |
eclare108213
requested changes
Mar 16, 2018
There was a problem hiding this comment.
These changes look fine to me, I just have some nit-picky requests:
There is a bunch of white space added in icepack_shortwave.F90, looks like tabs. Please revert those lines.
This makes the code easier to read: please delineate subroutines and functions with the divider line
!=============... (it has a standard length)
|
Made the changes as requested. |
|
Thanks Dave. It looks like you did this from a branch on the main CICE repo rather than your fork. I'll merge it, but in the future please work in branches of your fork... |
eclare108213
approved these changes
Mar 16, 2018
eclare108213
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some additional Hobart support for Icepack. It runs under Intel, and currently only under NAG in DEBUG mode. I've also changed some statement functions to actual functions, which is more in line with the current Fortran standard.
Developer(s): D. Bailey
Are the code changes bit for bit, different at roundoff level, or more substantial? Should be bfb on machines other than Hobart.
Is the documentation being updated with this PR? (Y/N) N
If not, does the documentation need to be updated separately? (Y/N) N
"Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://cice-consortium.github.io/Icepack/
Please suggest code reviewers in the column at right.
Other Relevant Details: